Skip to content

doc: Update HTTP -> HTTPS in GOVERNANCE.md file - #17262

Closed
him2him2 wants to merge 1 commit into
nodejs:masterfrom
him2him2:_fix_GOVERNANCE.md_HTTPS
Closed

doc: Update HTTP -> HTTPS in GOVERNANCE.md file#17262
him2him2 wants to merge 1 commit into
nodejs:masterfrom
him2him2:_fix_GOVERNANCE.md_HTTPS

Conversation

@him2him2

@him2him2 him2him2 commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

URLs were updated to use HTTPS protocol in GOVERNANCE.md

Checklist
Affected core subsystem(s)

docs

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 22, 2017

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: can you please include the subsystem in the commit message and
doc: Update HTTP -> HTTPS in...

Shouldn't have to wait 48 hours

@MylesBorins MylesBorins added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 23, 2017
URLs were updated to use HTTPS protocol in GOVERNANCE.md
@him2him2
him2him2 force-pushed the _fix_GOVERNANCE.md_HTTPS branch from d04b3a1 to 6de4d0e Compare November 23, 2017 05:15
@him2him2 him2him2 changed the title Update HTTP -> HTTPS in GOVERNANCE.md file doc: Update HTTP -> HTTPS in GOVERNANCE.md file Nov 23, 2017
@apapirovski

Copy link
Copy Markdown
Contributor

Landed in 7f446f0

Thanks @him2him2!

apapirovski pushed a commit that referenced this pull request Nov 23, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@him2him2
him2him2 deleted the _fix_GOVERNANCE.md_HTTPS branch November 24, 2017 06:16
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants